Fix Rapier initialize hard-crash when launcher stdout pipe closes - #1448
Open
JoaoVitorBaggio wants to merge 1 commit into
Open
Fix Rapier initialize hard-crash when launcher stdout pipe closes#1448JoaoVitorBaggio wants to merge 1 commit into
JoaoVitorBaggio wants to merge 1 commit into
Conversation
|
|
Closing CurseForge/Overwolf while Minecraft stays open breaks the process stdout pipe. fern then panics on info! during Rapier3D.initialize (Windows os error 232), which previously crossed JNI and killed the JVM with hs_err. Ignore closed-pipe writes in the native logger and catch_unwind initialize like tick/step so failures become Java exceptions / crash reports.
JoaoVitorBaggio
force-pushed
the
fix/rapier-init-hard-crash
branch
from
August 7, 2026 19:16
62380df to
3e34d63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fernthen panics oninfo!duringRapier3D.initialize(Windows os error 232 / "pipe is being closed"), even though the physics scene was already constructed.EXCEPTION_UNCAUGHT_CXX_EXCEPTION/hs_err) with no Minecraft crash report.IgnoreClosedPipewriter, andcatch_unwindinitializethe same waytick/stepalready do, so failures become Java exceptions / crash reports instead.Related to #1269 (same
Rapier3D.initialize/hs_errsymptom; this PR definitively fixes the launcher-closed-stdout repro; other #1269 causes may still need separate investigation).Test plan
hs_err/ panic; with this native build — world loadscatch_unwindproduced a Minecraft crash report naming the closed-pipe panic (confirmed root cause)sable_rapiernatives so the Rust fix ships in a release jar